Skip to content

Listener: Use headless and metrics service #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Listener: Use headless and metrics service #651

wants to merge 4 commits into from
+212 −61

Conversation

maltesander
Copy link
Member

Description

  • split internal services into metrics and headless
  • currently only the webserver has a headless service

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this Jul 2, 2025
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Jul 2, 2025
@maltesander
Copy link
Member Author

test https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/35/

@Maleware Maleware self-requested a review July 3, 2025 14:06
@Maleware Maleware moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 3, 2025
Maleware
Maleware reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@maltesander maltesander requested a review from Maleware July 3, 2025 16:13
Maleware
Maleware approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@maltesander maltesander requested a review from Maleware July 4, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleware Maleware Awaiting requested review from Maleware

Assignees

@maltesander maltesander

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @Maleware